This repository was archived by the owner on Sep 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
graphqlbackend: update throttled to use Ctx stores #54748
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jhchabran what is the black magic one needs so that backcompat tests work after dependency updates? |
stefanhengl
approved these changes
Jul 11, 2023
ca65700
to
6a82bb6
Compare
rebased and added a commit which fixed the lint errors. Doing that also made me realise the the RateLimit struct was unused, so I just removed it. |
It seems we were using a weird version of throttled which I don't think was actually based on the v2 series correctly. This updates us to the latest version and moves us away from the removed struct GCRARateLimiter and the deprecated interface GCRAStore. I came across this while attempting to update deps and getting failing compiles. Test Plan: we have unit tests for this, so CI.
6a82bb6
to
7bf85c2
Compare
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.1 5.1
# Navigate to the new working tree
cd .worktrees/backport-5.1
# Create a new branch
git switch --create backport-54748-to-5.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c390e4bacb1e233aea179840f8ce0e5e56695527
# Push it to GitHub
git push --set-upstream origin backport-54748-to-5.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.1 Then, create a pull request where the |
ggilmore
pushed a commit
that referenced
this pull request
Aug 21, 2023
It seems we were using a weird version of throttled which I don't think was actually based on the v2 series correctly. This updates us to the latest version and moves us away from the removed struct GCRARateLimiter and the deprecated interface GCRAStore. I came across this while attempting to update deps and getting failing compiles. Test Plan: we have unit tests for this, so CI. (cherry picked from commit c390e4b)
coury-clark
pushed a commit
that referenced
this pull request
Aug 21, 2023
It seems we were using a weird version of throttled which I don't think was actually based on the v2 series correctly. This updates us to the latest version and moves us away from the removed struct GCRARateLimiter and the deprecated interface GCRAStore. I came across this while attempting to update deps and getting failing compiles. Test Plan: we have unit tests for this, so CI. (cherry picked from commit c390e4b) Co-authored-by: Keegan Carruthers-Smith <keegan.csmith@gmail.com>
jhchabran
added a commit
that referenced
this pull request
Aug 24, 2023
jdpleiness
pushed a commit
that referenced
this pull request
Aug 24, 2023
…e ngram sort optimization (#56200) * gomod: update zoekt to include ngram sort optimization (#54999) Main motivation is to see the effect on performance for attribution search. Note that this included a bump in the otel version used since zoekt is using a new version. This had a bit of a cascading effect on our third party deps since they removed a package. So this bumps most 3rd party packages that directly interacted with otel. The changed commits are sourcegraph/zoekt@7643f3b...45f608f - a176bde1a3 go get -u -t ./... - e2e8aede00 Fix template documentation comments - 25c1ea5177 all: observe missing Stats RegexpsConsidered and FlushReason - 9abbb8b0d3 zoekt-indexserver: Prevent invalid config from causing an NPE - 008a775ba8 zoekt-indexserver: use value format directive for bad conf warning - f9d3a0e2e4 zoekt: add fgprof for full profiling - 3d0bdd5c9c remove ngram offset code - 45f608ff95 sort ngrams before looking them up Test Plan: tested in the zoekt repo. Our CI will handle the dep updates. I eyeballed them and they all look low risk. Co-authored-by: Jean-Hadrien Chabran <jh@chabran.fr> * search: update zoekt with removal of RepositoryRankRequest (#54394) This endpoint was unused which was why it was removed in Zoekt. The changes from Zoekt included in this dep bump: - 1686b50d50 indexserver: remove unused GetRepoRank - 7078a585a9 shards: populate RepoList.Stats.Repos - b9e6d9433e zoekt-indexserver: Check stderr for git fetch - 93f7b0c983 matchtree: capture Stats before pruning - 7643f3b313 matchiter: capture metric NgramLookups Test Plan: CI * fix bazel deps and patches * fix bad merge and update backcompat zoekt * update go.sum for github.com/jackc/pgproto3/v2 * fix go.sum dependency * restore backcompat throttled repo * Revert "restore backcompat throttled repo" This reverts commit e5f66b3. * Fix backcompat by porting #54748 * allow mozilla 2.0 license for retryablehttp --------- Co-authored-by: Keegan Carruthers-Smith <keegan.csmith@gmail.com> Co-authored-by: Jean-Hadrien Chabran <jh@chabran.fr> Co-authored-by: ggilmore <geoffrey@sourcegraph.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backports
cla-signed
release-blocker
Prevents us from releasing: https://about.sourcegraph.com/handbook/engineering/releases
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems we were using a weird version of throttled which I don't think was actually based on the v2 series correctly. This updates us to the latest version and moves us away from the removed struct GCRARateLimiter and the deprecated interface GCRAStore.
I came across this while attempting to update deps and getting failing compiles.
Test Plan: we have unit tests for this, so CI.