This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Cleanup auth and init pages design #57430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR wraps up the outstanding changes mentioned in https://github.com/sourcegraph/sourcegraph/issues/14773 and designed in https://www.figma.com/file/L5ZdNBGAnHQQUGGmp6tdQS/%2312695-%E2%80%93-Sign-in-%2F-Out-UX-%5BDone%5D?type=design&node-id=17-2040&mode=design&t=gJokKWRG2kC09J9M-0. Since all the implementations of the pages were done slightly different, I consolidated them. I also added a bunch of stories for easier review and regression testing. No one wants the login page to break :)
pjlast
approved these changes
Oct 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wraps up the outstanding changes mentioned in https://github.com/sourcegraph/sourcegraph/issues/14773 and designed in https://www.figma.com/file/L5ZdNBGAnHQQUGGmp6tdQS/%2312695-%E2%80%93-Sign-in-%2F-Out-UX-%5BDone%5D?type=design&node-id=17-2040&mode=design&t=gJokKWRG2kC09J9M-0.
Since all the implementations of the pages were done slightly different, I consolidated them. I also added a bunch of stories for easier review and regression testing. No one wants the login page to break :)
Please use the Chromatic diff for review! Edit: For some reason no diff was generated.. Please look at the stories under web/auth
Closes https://github.com/sourcegraph/sourcegraph/issues/14773
Test plan
Wrote storybooks, and verified login and site init still work locally.