This repository was archived by the owner on Sep 30, 2024. It is now read-only.
client: Minor cleanup for search-based code intel #58331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varungandhi-src
changed the title
varungandhi-src
force-pushed
the
vg/simplify-searchbased
branch
from
8cd2e48 to
8093f77
Compare
varungandhi-src
commented
Nov 22, 2023
keynmol
reviewed
Nov 22, 2023
varungandhi-src
force-pushed
the
vg/simplify-searchbased
branch
from
6c661ca to
aa04fc4
Compare
fkling
approved these changes
Nov 24, 2023
| getSetting, | ||
| filter, | ||
| }: UseSearchBasedCodeIntelOptions): Promise<Location[]> { | ||
| function searchBasedReferencesViaSCIPLocals(options: UseSearchBasedCodeIntelOptions): Location[] | undefined { |
There was a problem hiding this comment.
Just for my understanding: This is "search based" because, although using SCIP, we don't actually have any connections between the occurrences/symbols. We are just looking up occurrences by name (or something like that)?
There was a problem hiding this comment.
Right now, "search based" is the catch-all term for anything that is not precise (i.e. coming from a compiler/type-checker). In this case, the SCIP Document that is attached to the blob view came from the syntax highlighter, which is able to add information about local symbols using purely tree-sitter for some languages.
That's why this is "search based".
SCIP as a protocol does not dictate what the source of SCIP data is. We have multiple producers, such as the syntax highlighter, compilers etc.
vovakulikov
pushed a commit
that referenced
this pull request
Dec 12, 2023
The separation of the logic into different functions makes it clearer what the order of searches is. It also makes it clearer that for some reason, we're only using the locals information from the SCIP Document for 'Find references', and not for 'Go to definition'. Using the SCIP Document for for 'Go to definition' too could avoid a network request.
varungandhi-src
added a commit
that referenced
this pull request
Jan 16, 2024
The separation of the logic into different functions makes it clearer what the order of searches is. It also makes it clearer that for some reason, we're only using the locals information from the SCIP Document for 'Find references', and not for 'Go to definition'. Using the SCIP Document for for 'Go to definition' too could avoid a network request. (cherry-picked from e955cddec490d0cc2b5eba36be2ec4958ba06bf8)
Closed
varungandhi-src
added a commit
that referenced
this pull request
Jan 17, 2024
The separation of the logic into different functions makes it clearer what the order of searches is. It also makes it clearer that for some reason, we're only using the locals information from the SCIP Document for 'Find references', and not for 'Go to definition'. Using the SCIP Document for for 'Go to definition' too could avoid a network request. (cherry-picked from e955cddec490d0cc2b5eba36be2ec4958ba06bf8)
varungandhi-src
added a commit
that referenced
this pull request
Jan 23, 2024
The separation of the logic into different functions makes it clearer what the order of searches is. It also makes it clearer that for some reason, we're only using the locals information from the SCIP Document for 'Find references', and not for 'Go to definition'. Using the SCIP Document for for 'Go to definition' too could avoid a network request. (cherry-picked from e955cddec490d0cc2b5eba36be2ec4958ba06bf8)
BolajiOlajide
pushed a commit
that referenced
this pull request
Jan 24, 2024
…58954) (#59636) * client: Minor cleanup for search-based code intel (#58331) The separation of the logic into different functions makes it clearer what the order of searches is. It also makes it clearer that for some reason, we're only using the locals information from the SCIP Document for 'Find references', and not for 'Go to definition'. Using the SCIP Document for for 'Go to definition' too could avoid a network request. (cherry-picked from e955cddec490d0cc2b5eba36be2ec4958ba06bf8) * client: Avoid complex tokenization in ref panel code (#58954) Previously, we relied on detecting the language from file paths, then using various regexes associated with the language to identify token boundaries. However, the code mirror blob view always provides a full token range, which can be used directly, instead of attempting to recompute the token boundaries. For older URLs, we fallback to simple identifiers, which should work for the vast majority of languages and identifiers. We cannot yet remove the language detection here because the file extensions associated with the language are later used for search-based code navigation. This patch also makes the language spec optional for search-based code intel, as we do not have a solution to #56376 which would guarantee that we always have a language available. If a language is not available, search-based code intel falls back to searching other files with the same extension as a best effort guess. Locally tested for MATLAB code. The ref panel shows up correctly, unlike the error earlier. (cherry-picked from c42cad2) * Fix lint error due to short variable name
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The separation of the logic into different functions makes it clearer
what the order of searches is. It also makes it clearer that for some
reason, we're only using the locals information from the SCIP
Document for 'Find references', and not for 'Go to definition'.
Using the SCIP Document for for 'Go to definition' too could avoid
a network request.
Test plan
TODO:
sg start web-standalone