Replace terminal UI with a more readable logger when src actions exec is run in verbose mode #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseliger
approved these changes
Feb 24, 2020
| diffSupportsNoDereference, err = diffSupportsFlag(ctx, "--no-dereference") | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if !diffSupportsNoDereference { | ||
| logger.Warnf("Local installation of 'diff' doesn't support '%s' flag. Consider upgrading to GNU diff >=3.7.\n", "--no-dereference") |
There was a problem hiding this comment.
3.3 I think. For some reason the suggestion button is disabled so I cannot make one 🤦
There was a problem hiding this comment.
You think this is necessary? Newest version is 3.7, I think we should recommend upgrading to that :)
There was a problem hiding this comment.
yup definitely makes sense to have people use always the most recent version, I was thinking it might confuse people when they are on some OS that doesn't have 3.7 in their package lists that they cannot use src-cli, but it might be unreasonable to account for that 😁
There was a problem hiding this comment.
Let's stay with this for now, since I also want to explore some other options (to fix #137) and this might be invalidated soon.
57 tasks
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
… is run in verbose mode (#140) * Change verbose mode of action exec and not show UI * Introduce actionLogger and print everything through it in verbose mode * Send generic system messages to actionLogger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
src action execpreviously ran in verbose-mode with the-vflag, it looked like this:With the changes in this PR it looks like this:
Please note: I didn't focus on the details (such as colors, exact words in message, etc). The goal was to untangle the logging from the
actionExecutorand the terminal UI, while keeping the behavior in place:-keep-logsflag is given or the repo didn't produce an errorThis fixes #119