-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change wording of "cached result found" log message #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, tweaking one more time now that I'm looking at it :)
Thoughts on diff vs. patch? I like diff because it reminds me of git diff
, but I know we've also been using patches in a lot of our other language.
Thanks!
Co-Authored-By: Christina Forney <christina@sourcegraph.com>
Co-Authored-By: Christina Forney <christina@sourcegraph.com>
I honestly prefer |
I just found this: https://devmanual.gentoo.org/tools-reference/diff-and-patch/index.html and https://stackoverflow.com/questions/4215722/difference-between-patch-and-diff-files I think we can choose what we'd like. One person on stack overflow said "patch is a collection of diffs", but that doesn't seem to be widely adopted. The gentoo devmanual is probably a better standard to goo off of:
So we can choose whatever we'd like and right now we're 2/2 for |
* Change wording of log message * Update cmd/src/actions_exec_logger.go Co-Authored-By: Christina Forney <christina@sourcegraph.com> * Update cmd/src/actions_exec_logger.go Co-Authored-By: Christina Forney <christina@sourcegraph.com> Co-authored-by: Christina Forney <christinaforney.web@gmail.com>
@christinaforney I hit "merge" too early in the other PR, so here's a follow-up with your suggestion.