Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change wording of "cached result found" log message #146

Merged
merged 3 commits into from
Mar 2, 2020

Conversation

mrnugget
Copy link
Contributor

@christinaforney I hit "merge" too early in the other PR, so here's a follow-up with your suggestion.

Copy link
Contributor

@christinaforney christinaforney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, tweaking one more time now that I'm looking at it :)

Thoughts on diff vs. patch? I like diff because it reminds me of git diff, but I know we've also been using patches in a lot of our other language.

Thanks!

mrnugget and others added 2 commits February 28, 2020 17:41
Co-Authored-By: Christina Forney <christina@sourcegraph.com>
Co-Authored-By: Christina Forney <christina@sourcegraph.com>
@mrnugget
Copy link
Contributor Author

Thoughts on diff vs. patch? I like diff because it reminds me of git diff, but I know we've also been using patches in a lot of our other language.

I honestly prefer diff but I always assumed that patch sounds more correct?

@christinaforney
Copy link
Contributor

I just found this: https://devmanual.gentoo.org/tools-reference/diff-and-patch/index.html and https://stackoverflow.com/questions/4215722/difference-between-patch-and-diff-files

I think we can choose what we'd like. One person on stack overflow said "patch is a collection of diffs", but that doesn't seem to be widely adopted. The gentoo devmanual is probably a better standard to goo off of:

"The diff tool is used to create patches (sometimes called diffs)"

So we can choose whatever we'd like and right now we're 2/2 for diff.

@mrnugget mrnugget merged commit c3b659c into master Mar 2, 2020
scjohns pushed a commit that referenced this pull request Apr 24, 2023
* Change wording of log message

* Update cmd/src/actions_exec_logger.go

Co-Authored-By: Christina Forney <christina@sourcegraph.com>

* Update cmd/src/actions_exec_logger.go

Co-Authored-By: Christina Forney <christina@sourcegraph.com>

Co-authored-by: Christina Forney <christinaforney.web@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants