TODO after making changes in website - app.js #178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suprith KG <suprith7kg@gmail.com>
suprith-hub
changed the title
suprith-hub
changed the title
|
Let me take a look later today. I'll try to run it locally. I'm still baffled about why GitHub Actions are not triggering for you :( |
okay great.. 👍 |
|
Can you sync your PR branch with the latest stuff from |
Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Signed-off-by: Suprith KG <suprith7kg@gmail.com>
I am getting some merge conflicts, I will resolve that and CI tests are working good.. |
|
Looks like its all green, but you need to perform the DCO with |
Bumps [tap](https://github.com/tapjs/node-tap) from 16.3.6 to 16.3.7. - [Release notes](https://github.com/tapjs/node-tap/releases) - [Commits](tapjs/tapjs@v16.3.6...v16.3.7) --- updated-dependencies: - dependency-name: tap dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Bumps [@codemirror/lint](https://github.com/codemirror/lint) from 6.2.2 to 6.3.0. - [Changelog](https://github.com/codemirror/lint/blob/main/CHANGELOG.md) - [Commits](codemirror/lint@6.2.2...6.3.0) --- updated-dependencies: - dependency-name: "@codemirror/lint" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Bumps [webpack](https://github.com/webpack/webpack) from 5.88.0 to 5.88.1. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.88.0...v5.88.1) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Bumps [@codemirror/lint](https://github.com/codemirror/lint) from 6.3.0 to 6.4.0. - [Changelog](https://github.com/codemirror/lint/blob/main/CHANGELOG.md) - [Commits](codemirror/lint@6.3.0...6.4.0) --- updated-dependencies: - dependency-name: "@codemirror/lint" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Bumps [webpack](https://github.com/webpack/webpack) from 5.88.1 to 5.88.2. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.88.1...v5.88.2) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Bumps [json-e](https://github.com/json-e/json-e) from 4.5.2 to 4.5.3. - [Changelog](https://github.com/json-e/json-e/blob/main/CHANGELOG.rst) - [Commits](json-e/json-e@v4.5.2...v4.5.3) --- updated-dependencies: - dependency-name: json-e dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Bumps [bootstrap](https://github.com/twbs/bootstrap) from 5.3.0 to 5.3.1. - [Release notes](https://github.com/twbs/bootstrap/releases) - [Commits](twbs/bootstrap@v5.3.0...v5.3.1) --- updated-dependencies: - dependency-name: bootstrap dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Bumps [tap](https://github.com/tapjs/node-tap) from 16.3.7 to 16.3.8. - [Release notes](https://github.com/tapjs/node-tap/releases) - [Commits](tapjs/tapjs@v16.3.7...v16.3.8) --- updated-dependencies: - dependency-name: tap dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Bumps [@codemirror/lint](https://github.com/codemirror/lint) from 6.4.0 to 6.4.1. - [Changelog](https://github.com/codemirror/lint/blob/main/CHANGELOG.md) - [Commits](codemirror/lint@6.4.0...6.4.1) --- updated-dependencies: - dependency-name: "@codemirror/lint" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Bumps [bootstrap](https://github.com/twbs/bootstrap) from 5.3.1 to 5.3.2. - [Release notes](https://github.com/twbs/bootstrap/releases) - [Commits](twbs/bootstrap@v5.3.1...v5.3.2) --- updated-dependencies: - dependency-name: bootstrap dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Bumps [@codemirror/lint](https://github.com/codemirror/lint) from 6.4.1 to 6.4.2. - [Changelog](https://github.com/codemirror/lint/blob/main/CHANGELOG.md) - [Commits](codemirror/lint@6.4.1...6.4.2) --- updated-dependencies: - dependency-name: "@codemirror/lint" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Removes [tough-cookie](https://github.com/salesforce/tough-cookie). It's no longer used after updating ancestor dependency [tap](https://github.com/tapjs/tapjs). These dependencies need to be updated together. Removes `tough-cookie` Updates `tap` from 16.3.8 to 18.0.3 - [Release notes](https://github.com/tapjs/tapjs/releases) - [Commits](https://github.com/tapjs/tapjs/compare/v16.3.8...tap@18.0.3) --- updated-dependencies: - dependency-name: tough-cookie dependency-type: indirect - dependency-name: tap dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Signed-off-by: Suprith KG <suprith7kg@gmail.com>
This reverts commit a709674.
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com> Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com> Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com> Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Signed-off-by: Suprith KG <suprith7kg@gmail.com>
Signed-off-by: Suprith KG <suprith7kg@gmail.com>
|
Hi, @jviotti it is asking me to resolve all 38 commits which includes your commits too, when I use this command: |
|
That's weird. I didn't do that many commits. Yes, whatever is easier. Feel free to close and send another one. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But I wasn't able to test website in local. I hope CI takes care of it, if can I view for errors in the deployments if any in the website It would have been better