Enable clang-tidy at target level #1844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
jviotti
reviewed
Jul 17, 2025
src/core/yaml/CMakeLists.txt
Outdated
| sourcemeta_library(NAMESPACE sourcemeta PROJECT core NAME yaml | ||
| PRIVATE_HEADERS error.h | ||
| SOURCES yaml.cc) | ||
| sourcemeta_clang_tidy_attempt_enable(TARGET_NAME "sourcemeta_core_yaml") |
There was a problem hiding this comment.
Can you instead do this by default on the definition of sourcemeta_library and sourcemeta_executable? Then you don't have to add it for every library
jviotti
reviewed
Jul 17, 2025
cmake/common/clang-tidy.cmake
Outdated
|
|
||
| function(sourcemeta_clang_tidy_attempt_disable) | ||
| unset(CMAKE_CXX_CLANG_TIDY PARENT_SCOPE) | ||
| set_target_properties("${SOURCEMETA_CLANG_TIDY_TARGET_NAME}" |
There was a problem hiding this comment.
Did you confirm this works? I haven't tried it yet, but when I tried your past PR, it wouldn't seem to like it called ClangTidy at all
There was a problem hiding this comment.
This is tested locally
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
jviotti
approved these changes
Jul 18, 2025
|
Ah, I think there is a conflict on the removal of the C++ standard. I'll let you fix that and then we can merge |
|
@jviotti The conflict is resolved. Can we merge this? |
bavulapati
force-pushed
the
clang-tidy-target-level
branch
from
c606fa8 to
176e98d
Compare
|
@jviotti Let's merge this before others to avoid merge conflicts on this PR. |
jviotti
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #1824 (comment)