Skip to content

Expose caf_init and caf_finalize in module to allow use with f2py, see #204 #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2016

Conversation

zbeekman
Copy link
Collaborator

Fixes #204

At configure time, choose whether to expose the caf_init and
caf_finalize functions in the opencoarrays (extension) module by using -DCAF_EXPOSE_INIT_FINALIZE.

N.B. the semantics of using C pointers with Fortran still mystifies me a bit, and I don't really understand what the point of passing argc and argv to MPI_init is (since I always use fortran, where the only arg is ierr). So for my interface to caf_init which takes argc and argv as arguments, I have declared both as type(c_ptr) so it is the users responsibility to pass the appropriate c_ptr in to them. In my testing I just passed c_null_ptrs and it seemed to work fine. Also, please note, that the caf compiler wrapper script does not pass in the installed module file for open coarrays aware (OCA) compilers (GCC/GFortran) to the compiler, so you'll have to add something like -J/usr/local/mod or whatever to the caf script if you use it and want the compiler to find your installed module file and compile time.

@amckinstry: will this suit your needs? Please take a look and let me know if you need any changes.

@zbeekman zbeekman force-pushed the issue-204-expose-init-finalize branch from e48137d to f1711cd Compare November 11, 2016 21:09
@codecov-io
Copy link

codecov-io commented Nov 11, 2016

Current coverage is 48.18% (diff: 100%)

Merging #251 into master will not change coverage

@@             master       #251   diff @@
==========================================
  Files             2          2          
  Lines           907        907          
  Methods          42         42          
  Messages          0          0          
  Branches        195        195          
==========================================
  Hits            437        437          
  Misses          392        392          
  Partials         78         78          

Sunburst

Powered by Codecov. Last update 13a6255...37900d4

 Fixes #204
 At configure time, choose whether to expose the caf_init and
 caf_finalize functions in the opencoarrays (extension) module.
@zbeekman zbeekman force-pushed the issue-204-expose-init-finalize branch from f1711cd to 981d6cd Compare November 12, 2016 00:50
@zbeekman
Copy link
Collaborator Author

zbeekman commented Nov 12, 2016

LGTM

Approved with PullApprove

@zbeekman zbeekman merged commit 611ee79 into master Nov 12, 2016
@zbeekman zbeekman deleted the issue-204-expose-init-finalize branch November 12, 2016 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants