Issue 340 permission fix #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's move Summary of Changes and Rationale for Changes to the top of this file and the template(s). |
Codecov Report
@@ Coverage Diff @@
## master #345 +/- ##
=======================================
Coverage 46.22% 46.22%
=======================================
Files 3 3
Lines 1045 1045
Branches 201 201
=======================================
Hits 483 483
Misses 483 483
Partials 79 79 |
zbeekman
force-pushed
the
issue-340-permission-fix
branch
from
608f28e to
2e38f3c
Compare
- Update `caf` and `cafrun` to use the more portable shebang `#!/usr/bin/env bash` rather than the old `#!/usr/bin/bash` - The user/system bash will get used
|
@rouson if you have a chance to look at this and give it a "LGTM" or provide comment that would be great. Feel free to merge too, I'm done. If this happens in the next 5 min I'll try to upload release assets before going to the gym. Otherwise I'll do it when I return. |
|
LGTM |
|
@zbeekman, I'll let you merge in case you want to wait for the tests to complete. |
|
They were about to finish but then I realized the release signing and
deploy script would error on the tag build. My changes shouldn't impact
non-tag builds and I probably should have added `[ci-skip]`. Feel free to
merge if the second to last commit has a green check. This will help clear
any ci backlog whil I'm at the gym.
…On Tue, Apr 18, 2017 at 6:26 PM Damian Rouson ***@***.***> wrote:
@zbeekman <https://github.com/zbeekman>, I'll let you merge in case you
want to wait for the tests to complete.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#345 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAREPFVoTGAr_p2SLuHXxCwFspNTff0Pks5rxTidgaJpZM4MkFUf>
.
|
|
LGTM
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request (PR) is a:
I certify that:
WIP:to thebeginning of the PR title
DO NOT MERGE:to the beginning of the titleissue-<#>where<#>is replaced by the issue that this PRis addressing
touches
touches
changes
ctest) and all tests passset of changes
imperative verb, and is no longer than 50 characters
summarizing your commit
include additional paragraphs, bulleted lists, etc.
commit resolves an open issue.
clicking the "details" link to the right of the
licence/clacheck and following the directions on the CLA assistant webpage
Summary of changes
Made installed scripts 555 permissions
Rationale for changes
Installed software should not be group or world writeable, since this is a huge security vulnerability, obviously.
For contributors and SI team members with code review priviledges
pullapprove comment or Github code review so that someone
else has the chance to review my proposed changes