Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1571 @mr-eyes mentioned he couldn't run the
asv
benchmarks. I also had problems fixing them for #1564. It seems that one of the main issues is thatvirtualenv
was using a very old version (becauseasv
had issues with newer versions), but it seemed to be fixed and it is working with newervirtualenv
again).This PR avoid pinning the
virtualenv
version, and is enough to make it work in my system.@mr-eyes, can you try this branch and see if benchmarks (with
tox -e asv
) work?