Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] fix, refactor, and test sourmash sketch output information. #1826

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Feb 3, 2022

This PR:

This PR also adds explicit checks on sourmash output signature counts, which hopefully will start locking down the repeated mistakes I'm making when I change this code 🙄 .

Fixes #1824

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #1826 (1a0d5ba) into latest (d361539) will increase coverage by 6.71%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1826      +/-   ##
==========================================
+ Coverage   83.48%   90.20%   +6.71%     
==========================================
  Files         113       87      -26     
  Lines       12183     8481    -3702     
  Branches     1627     1628       +1     
==========================================
- Hits        10171     7650    -2521     
+ Misses       1754      573    -1181     
  Partials      258      258              
Flag Coverage Δ
python 90.20% <100.00%> (+0.04%) ⬆️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/command_compute.py 93.35% <100.00%> (+1.15%) ⬆️
src/sourmash/sourmash_args.py 92.88% <100.00%> (+0.13%) ⬆️
src/core/src/ffi/utils.rs
src/core/src/ffi/hyperloglog.rs
src/core/src/ffi/mod.rs
src/core/src/sketch/minhash.rs
src/core/tests/test.rs
src/core/src/index/bigsi.rs
src/core/src/errors.rs
src/core/src/index/sbt/mhbt.rs
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d361539...1a0d5ba. Read the comment docs.

@ctb ctb changed the title [MRG] fix, refactor, and test [MRG] fix, refactor, and test sourmash sketch output code. Feb 3, 2022
@ctb ctb changed the title [MRG] fix, refactor, and test sourmash sketch output code. [MRG] fix, refactor, and test sourmash sketch output information. Feb 3, 2022
@ctb ctb changed the title [MRG] fix, refactor, and test sourmash sketch output information. [MRG] fix, refactor, and test sourmash sketch output information. Feb 3, 2022
@ctb
Copy link
Contributor Author

ctb commented Feb 3, 2022

Ready for review, and probably merge, @sourmash-bio/devs.

Copy link
Member

@mr-eyes mr-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ctb ctb merged commit cad2314 into latest Feb 3, 2022
@ctb ctb deleted the fix/sketch_output branch February 3, 2022 16:46
@ctb
Copy link
Contributor Author

ctb commented Feb 3, 2022

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

display of output number of signatures is wrong with sourmash sketch ...
2 participants