Create a custom resource to install golang #82
Conversation
|
Thanks @MarkGibbons! Looks like the source installs came unstuck for some reason. I’ll try to review this a bit more tomorrow. |
There was a problem hiding this comment.
@MarkGibbons great stuff! One request, in a line comment. If you’ve a specific reason for doing it this way though, I’m all ears 🙂
resources/default.rb
Outdated
| # ark input source | ||
| property :source_url, String, required: true | ||
| # ark input binaries and stuff download | ||
| property :url, String, required: true |
There was a problem hiding this comment.
@MarkGibbons one suggestion here: like the other properties, I think these should have default URLs, which mimic the attributes:
default['golang']['url'] = "https://dl.google.com/go/#{node['golang']['filename']}"
default['golang']['source_url'] = "https://dl.google.com/go/#{node['golang']['source_filename']}"That will ease the next version, where we drop the attributes & recipes entirely.
There was a problem hiding this comment.
Thanks, makes sense. I'll see what I can do.
MarkGibbons
changed the title
|
Took off the WIP. I could squash the commits, just don't have time this week. |
Markdown lint fixes Remove the owner, group, mode attributes Defaults are set in the resource, update the resource property settings as needed. Set a partial default for the golang download locationss Compute the package name to download for the binary and source golang packages
MarkGibbons
force-pushed
the
golang_resource
branch
from
7250538
to
837eb45
Compare
|
I changed how the download image is computed and the locations are no longer required properties, they have defaults inside the resource. |
There was a problem hiding this comment.
Looks great! Thanks for all the hard work on this big refactor, @MarkGibbons.
jeffbyrnes
added
Release: Minor
Description
Create a custom resource to install Golang. Two methods of installation are provided: download a binary version or download a binary version and compile. Compiling Golang requires an existing go binary.
Issues Resolved
List any existing issues this PR resolves
Check List