Making all set actions explicit. #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will use the 'do' keyword for newer rvms.
| module SetHelpers | ||
| def rvm_do(user = nil) | ||
| # Use Gem's version comparing code to compare the two strings | ||
| if Gem::Version.new(VersionCache.fetch_version(user)) <= Gem::Version.new("1.8.6") |
There was a problem hiding this comment.
@fnichol: If you hate abusing Gem this way, we can pull in versionomy (https://github.com/dazuma/versionomy) to do it instead.
|
Freaking awesome dude! I just started working on this problem and found I missed reading the github pull request email. Pretty much the same implementation path too :) Let me run this through a VM and I'll get this pulled. |
|
:-D Glad you like it! This cookbook has solved so many of my rvm+chef issues. |
fnichol
added a commit
that referenced
this pull request
Oct 15, 2011
fnichol
added a commit
that referenced
this pull request
Oct 15, 2011
fnichol
added a commit
that referenced
this pull request
Oct 15, 2011
|
This looks to do the trick, thanks to @ryansch |
phlipper
pushed a commit
to newleaders/chef-rvm
that referenced
this pull request
Feb 1, 2012
phlipper
pushed a commit
to newleaders/chef-rvm
that referenced
this pull request
Feb 1, 2012
phlipper
pushed a commit
to newleaders/chef-rvm
that referenced
this pull request
Feb 1, 2012
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will use the 'do' keyword for newer rvms and 'exec' for older rvms.
This is my first pass at functionality. I've got it working in both test environments with rvm 1.6.5 and rvm head. If you like it, I'll add some documentation.