Use a less strict test for deleting cookies #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My environment uses the following in this test: "foo=; expires=Thu, 01-Jan-1970 00:00:00 GMT" I'm guessing the test should still be considered passing in this case, but if there is a reason to consider this a failure, it should probably be fixed in the code.
|
We discussed this briefly over IRC, and @jeremyevans was running the tests with Rack |
|
I think this is a dup of #44. Now that the contributing section specifies that you should install the dependencies from |
|
Closing this for now. If we continue discussing and change our minds, we can reopen it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My environment uses the following in this test:
"foo=; expires=Thu, 01-Jan-1970 00:00:00 GMT"
I'm guessing the test should still be considered passing in this
case, but if there is a reason to consider this a failure, it
should probably be fixed in the code.