-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brand New Parser #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is most likely not a complete-complete code review, but I spotted some important things and (hopefully) gave some thought to investigate further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe suggestions might be committed.
Rename triple to macro
About committing changes, I try to check the regression every time, and when all code is modified in editor, it becomes hard to commit, requiring rebase. Maybe I have to read something about workflow with suggestions. |
Kernel.and(true, false) - done; true |> Kernel.and(true) - in commented test, need to implement pipes parsing
Looks like almost done. What did I forget or maybe gave a weird name? |
- Parse Structures %{} and <<>> - Simple and Qualified calls - Add metadata to when, structures and other - Group tests in describe for readability
{:ok, regex} = Regex.compile("#{project}.ex") | ||
|
||
with {:ok, files} <- File.ls(path), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should parse at least next clauses: