Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix false positives #577

Merged
merged 1 commit into from
Aug 13, 2022
Merged

fix false positives #577

merged 1 commit into from
Aug 13, 2022

Conversation

fen0s
Copy link
Contributor

@fen0s fen0s commented Aug 13, 2022

No description provided.

@soxoj soxoj merged commit 3d87813 into soxoj:main Aug 13, 2022
@Andrejki
Copy link

Andrejki commented Aug 14, 2022

Hi.
How to actually fix false positives? I ve downloaded it now, so it is not fixed because this was solved 2 days ago.
Can you give a tutorial how to fix false positives?

Thank you for your effort in making these work, but with so many false positives it is like useless.
Kind regards

@fen0s
Copy link
Contributor Author

fen0s commented Aug 14, 2022

hi! this does not fix all of the false positives, only the ones we found recently. you could fix false positives by yourself if you fork maigret and edit data.json to fix the sites that give false positives and make a pull request, but more prefered way would be if you list false positives you found in an issue, and let us fix them :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants