Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move zip file methods to the NBugZipFile class. #79

Closed
wants to merge 1 commit into from
Closed

Move zip file methods to the NBugZipFile class. #79

wants to merge 1 commit into from

Conversation

Stef569
Copy link
Contributor

@Stef569 Stef569 commented Nov 10, 2016

Hello Teoman,

I refactored the BugReport class. I was looking at the CreateReportZip method and noticed that the if else logic could be replaced by 2 methods:
IsMaxReportingDaysExceeded and IsMaxQueuedReportCountExceeded

then I created a NBugZipFile and moved all the zip logic to that class.

I understand if you don't want to include this as it is a large change...

@soygul
Copy link
Owner

soygul commented Nov 11, 2016

CreateReportZip was gigantic and needed refactoring for a while. However since nbug has been in production by many, I'm also sure that it works as it should.

Now these changed require proper testing and I don't use Windows anymore so I'm not sure what to do.

@Stef569
Copy link
Contributor Author

Stef569 commented Nov 11, 2016

That's ok,

We can include this change later. Maybe in a new release?

Do you want me to close this PR?

@soygul
Copy link
Owner

soygul commented Nov 11, 2016

To be honest, at this point I can't approve any major changes or even make a new major release as I have no means to test it. I can only read and try to reason about changes as long as they are minor.

Automated testing coverage is also very basic so if you want to continue refactoring big stuff and making major changes, you can keep your own fork of the project.

For instance the biggest user of this library is gitextensions and they keep their own fork: https://github.com/gitextensions/NBug/network

@soygul soygul closed this Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants