Added ability to have multiple integrations with moving targets #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving_targets mode now works when requesting multiple integrations!! Similarly, imaging mode where moving targets are included in the field also works with more than 1 integration.
I also fixed a bug in the way the script was determining which moving targets do not overlap the detector.
As part of this, I added a new entry to the input yaml file resets_bet_ints lists the number of detector resets that happen between integrations within an exposure. For NIRCam this is 1 at the moment. This was done in order to get the relative timing between observations correct, which is important when there are moving targets in the field.
Finally, I chopped down galaxy stamp images such that the total stamp image contains 99.95% of the total normalized flux. The stamp images are still big (~650x650 pixels for a galaxy with a 1" half-light radius), but much smaller than they were previously (~1500x1500 pixels for the same case). This will speed up all work with galaxies, including any that happen to be moving across the field of view.