[osmFISH 2/5] Implement Laplacian Filter #687
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This filter enhances spots, and is used by the osmFISH pipeline. Under the hood, it's simply a call to
scipy.ndimage.gaussian_laplace
Note that there is no test for this filter. From offline conversations, it's not clear what our testing strategy for filters are. Especially for filters that are pulled in from existing libraries, like this one. Really, what we want to test here is that the Starfish specific wrapping code works as expected.
For now, I'll rely on [osmFISH 5/5] notebook to function as the test of this filter.