-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Allen Notebook #692
Fix Allen Notebook #692
Conversation
Codecov Report
@@ Coverage Diff @@
## master #692 +/- ##
=========================================
Coverage ? 87.51%
=========================================
Files ? 117
Lines ? 4045
Branches ? 0
=========================================
Hits ? 3540
Misses ? 505
Partials ? 0
Continue to review full report at Codecov.
|
Of note, the documentation in trackpy is wrong. The coordinates are emitted in (y, x) and (z, y, x). I verified by checking the coordinates of the maximum-valued spot in the imagestack and then finding the same value in the IntensityTable. |
d3bea7d
to
4e79535
Compare
FYI, tests were passing prior to rebase, so I believe this is probably clean/safe to land. I'll tag @dganguli for review for later, but we should get this in master and tested before he's back. |
notebooks/py/allen_smFISH.py
Outdated
# EPY: END markdown | ||
|
||
# EPY: START code | ||
primary_image.show_stack({Indices.CH.value: 0}); | ||
_ = primary_image.show_stack({Indices.CH.value: 0, Indices.Z.value: 17}, rescale=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you assigning this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done remember. Removed.
clip = Filter.Clip(p_min=10, p_max=100, is_volume=False) | ||
clip.run(primary_image, verbose=True, in_place=True) | ||
# EPY: END code | ||
|
||
# EPY: START code | ||
from showit import image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
showit!!
# image._show_spots(results, ax=plt.gca(), scale_radius=7); | ||
# if max radius is 3, and mean intensity is about 0.006, and we can expect spots to have around pi*r^2 integrated intensity... | ||
# try half-maximal radius * mean intensity | ||
(np.pi * 1.5 ** 2) * 0.006 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added explanation. Thanks for the catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove the .skip file while you're at it? :)
You likely will want to update .travis.yml as well. |
Fixes the Allen Notebook. Note that "use_test_data" doesn't seem to do anything?
The notebook still takes ~ 2.6GB of ram, presumably with a ceiling of + 1/3 when volumes are being manipulated. However, it's all starfish, and it runs.
Fixes #669