Use "Debug" build type for automatic testing on the develop branch #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmroAlJundi
approved these changes
Jan 26, 2022
Atahanak
approved these changes
Jan 28, 2022
SinanEkm
pushed a commit
that referenced
this pull request
Aug 19, 2024
…lds_on_develop Use "Debug" build type for automatic testing on the develop branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current setup automatic testing using Github Actions takes ~5 minutes on the
developbranch and ~10 minutes (~18 CPU minutes due to this involving two separate runs) on themainbranch. These are performed on every pull request, commit to a pull request and merge to the respective branch.There are 2 issues with this:
We can improve the situation for now by using "Debug" build type on cmake for the
developtests (which lowers the time to less than 1 minute). I believe it is not a good idea to do the same formaintests as this would reduce our coverage during releases and hotfixes.