error: 'U2TXD_OUT_IDX' was not declared in this scope

[EdwardDeaver]

Hi,

I'm trying to use this library with an esp32 Feather S2 from Unexpected Maker and I'm getting this issue when compiling the project.

SparkFun_DMX_Shield_Library/src/SparkFunDMX.cpp: In member function 'void SparkFunDMX::update()':
/SparkFun_DMX_Shield_Library/src/SparkFunDMX.cpp:127:31: error: 'U2TXD_OUT_IDX' was not declared in this scope
pinMatrixOutAttach(txPin, U2TXD_OUT_IDX, false, false);
^~~~~~~~~~~~~
SparkFun_DMX_Shield_Library/src/SparkFunDMX.cpp:127:31: note: suggested alternative: 'U1TXD_OUT_IDX'
pinMatrixOutAttach(txPin, U2TXD_OUT_IDX, false, false);
^~~~~~~~~~~~~
U1TXD_OUT_IDX

[romkey]

U2TXD_OUT_IDX isn't defined on the ESP32 S2 because it only has two UARTS. Vanilla (original) ESP32 and ESP32-S3 CPUs both have three UARTs.

[raypp2]

I'm having the same issue trying to use a SparkFun Thing Plus - ESP32-S2 WROOM with a SparkFun ESP32 Thing Plus DMX to LED Shield. In my case, I'm only trying to use the device to send and receive DMX commands. I am not controlling an LED fixture.
Have you found any workaround for this or does this issue mean that this library isn't compatible with the S2?

[romkey]

The library as it's written is not going to build for the S2. Either Sparkfun needs to update it or you need to make a copy and edit it to use U1TXD_OUT_IDX. I'm not sure if that's the only change needed to make it build and run correctly with an S2.

[raypp2]

Thanks John. I did quickly try updating the U2TXD_OUT_IDX value in the SparkFunDMX.cpp to both U0TXD_OUT_IDX and U1TXD_OUT_IDX but unfortunately the solution wasn't that simple for my situation. It does compile but I suspect that changing the pin would cause it to no longer work on the DMX shield.

I tested this on both the S2 and also tried loading the alternate UARTs onto a tested & working SparkFun Thing Plus original but that broke the DMX. It's not worth me testing different pinning right now because just using another S1 board is easier.

If anyone at SparkFun reads this and this is truly a compatibility issue, it would be helpful to put a notice on the DMX Shield and S2's product pages that they will not be compatible. The product page currently shows this text, which would be inaccurate if this bug is hardware based:

The DMX to LED shield is designed to work with the SparkFun Thing Plus - ESP32 WROOM or any board with a Feather footprint, so Feathers and Feather-Wings will fit it.

[brhoff720]

Hi @raypp2, We're looking into this, might be a longer to have a solution than we like, but working on squeezing this into the work queue. If you come up with a solution before we do, please put in a PR.

…

-Bryan

On Thu, Sep 21, 2023 at 6:55 PM raypp2 ***@***.***> wrote: Thanks John. I did quickly try updating the U2TXD_OUT_IDX value in the SparkFunDMX.cpp to both U0TXD_OUT_IDX and U1TXD_OUT_IDX but unfortunately the solution wasn't that simple for my situation. It does compile but I suspect that changing the pin would cause it to no longer work on the DMX shield. I tested this on both the S2 and also tried loading the alternate UARTs onto a tested & working SparkFun Thing Plus original but that broke the DMX. It's not worth me testing different pinning right now because just using another S1 board is easier. If anyone at SparkFun reads this and this is truly a compatibility issue, it would be helpful to put a notice on the DMX Shield and S2's product pages that they will not be compatible. The product page currently shows this text, which would be inaccurate if this bug is hardware based: The DMX to LED shield is designed to work with the SparkFun Thing Plus - ESP32 WROOM or any board with a Feather footprint, so Feathers and Feather-Wings will fit it. — Reply to this email directly, view it on GitHub <#10 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKLJJKFWZROCDH2VI35GDPLX3TAXLANCNFSM6AAAAAA4Z565PU> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[sfe-SparkFro]

Hi folks!

I've created #11 that I think fixes compatibility with the ESP32-S2, as well as our USB-C version of the ESP32 Thing Plus (the pinout is slightly different).

I've not had a chance to test it. @raypp2 or @EdwardDeaver any chance you're able to try it out and let me know how it goes? If all is well, I can merge the pull request and publish a new release. Thanks!

[pjpmarques]

Hi,

I've tried this patch with the ESP32 Thing Plus, USB-C version, and unfortunately it's not working for me.
It may be another issue (since the only thing I have is the DMX shield and the board), but I suspect there's still a compatibility issue involved.

[sfe-SparkFro]

Thank you for testing! Sorry that it didn't fix it, I'll dig a bit deeper and try to resolve the problem once I have some hardware to play with, and time to play with it 🕐

[pjpmarques]

Fyi -- Using the correct pins which are in the patch (Pin 4 - Enable, Pin 16 - RX, Pin 17 - TX), I got the board to work using the ESP32 Thing Plus, USB-C version, but not using the provided library. I've implemented the correct timings for detecting the start of data and the UART#2 to read the data packets. Thus, without going into "debugging mode" on the Sparkfun library, it seems to me that the problem is in the timings/timers/interrupts being used.

Snippet of my code (ugly, I know, but I was just trying to debug this):

  // ...
  uart.begin(DMX_BAUD, SERIAL_8N2, rx_pin, tx_pin);

  bool good_start = false;
  while (!good_start) {
    // Wait while RX is HIGH (idle)
    while (digitalRead(rx_pin) == HIGH)
        ;

    // We've detected RX became low, start counting time
    unsigned long t1 = micros();

    // Now the signal needs to be low for at least 88 usec
    while (true) {
        // If the signal becomes high before 88usec, it was a false start, if it continues low after that, it's a good start
        if (digitalRead(rx_pin) == HIGH) {
            break;
        }

        unsigned long t2 = micros();
        if (t2-t1 >= 88) {
            good_start = true;
            break;
        }
    }
  }

  // Ok, we have a good start with RX still low. Let's continue to monitor until it becomes HIGH
  while (digitalRead(rx_pin) == LOW)
    ;

  // Ok, RX is now HIGH, we can activate the UART for the rest of the decoding
  uart.flush(false);

// Read the 512 channels
// ....

[sfe-SparkFro]

Thanks for the code, that's helpful!

I've got some hardware and tinkered with it a bit today testing with Example 1 and 2. There was an issue with the timer here:

SparkFunDMX/src/SparkFunDMX.cpp

Line 70 in f8d1fdd

timer = timerBegin(0, 1, true);

E (31) timer_group: timer_init(275): HW TIMER divider outside of [2, 65536] range error
E (31) timer_group: timer_set_counter_value(86): HW TIMER NEVER INIT ERROR
E (35) timer_group: timer_start(97): HW TIMER NEVER INIT ERROR
E (40) timer_group: timer_isr_callback_add(227): HW TIMER NEVER INIT ERROR
E (47) timer_group: timer_set_alarm_value(155): HW TIMER NEVER INIT ERROR
E (53) timer_group: timer_set_auto_reload(132): HW TIMER NEVER INIT ERROR
E (60) timer_group: timer_set_alarm(179): HW TIMER NEVER INIT ERROR

Makes me wonder, did this ever work? Far as I can tell, the divider always needed to be at least 2 in the ESP-IDF, right? Idk. This library needs a serious overhaul, though I don't have time for that unfortunately.

I've pushed some commits to #11 that fix this, and some synchronization issues, and another spot where the UART number needed to be changed for the S2. I've got it working on my end with the ESP32 Thing Plus, ESP32 Thing Plus (USB-C), and ESP32-S2 Thing Plus.

@pjpmarques You mind testing it again quickly for me? Just want to make sure I've not broken anything 😉 If all is well, I'll merge it in.

[pjpmarques]

I've tried the new code and it's not working for me. Not sure why, since it seems to be because of the time as you said. I've using the library as this (connected to a proper DMX512 show controller with 192 channels). The test code is as follows:

#include <Arduino.h>
#include <HardwareSerial.h>
#include <SparkFunDMX.h>

SparkFunDMX dmx;

void setup() {  
  Serial.begin(115200);

  Serial.printf("\n\n\n\n\n");
  Serial.printf("Let's start reading this:\n\n"); 

  dmx.initRead(192);
}

void loop()
{
  dmx.update();

  for (int i=0; i<193; i++) {
    if (i%32 == 0) {
      Serial.printf("\n(%3i)  ", i);
    }
    Serial.printf("%4d", dmx.read(i));
  }

  Serial.printf("\n");
  delay(2000);
}

When the program starts, I get a timer error, saying it's not in range. Even though your code is setting it to 2.

Let's start reading this:

E (16) timer_group: timer_init(275): HW TIMER divider outside of [2, 65536] range error
E (17) timer_group: timer_set_counter_value(86): HW TIMER NEVER INIT ERROR
E (22) timer_group: timer_start(97): HW TIMER NEVER INIT ERROR
E (27) timer_group: timer_isr_callback_add(227): HW TIMER NEVER INIT ERROR
E (34) timer_group: timer_set_alarm_value(155): HW TIMER NEVER INIT ERROR
E (41) timer_group: timer_set_auto_reload(132): HW TIMER NEVER INIT ERROR
E (47) timer_group: timer_set_alarm(179): HW TIMER NEVER INIT ERROR

(  0)     0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0
( 32)     0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0
( 64)     0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0
( 96)     0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0
(128)     0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0
(160)     0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0
(192)     0

And I've checked, your code is setting the divisor to 2:

timer = timerBegin(0, 2, true);

Paulo

[sfe-SparkFro]

Thanks Paulo, I appreciate your time on this!

Hmm, that's odd. Could you please double check that you've correctly grabbed the code from #11? Do you happen to have 2 copies of this library downloaded? Also please try restarting Arduino. The fact that you're getting that error message indicates to me that Arduino is not compiling the latest code from #11

[pjpmarques]

Hi,

You are correct. Sorry, my fault (too tired). The build was grabbing the old library. Even so, with the new code it's not correctly reading from a "proper DMX controller". Here's what I get running the code (zeros in all channels):

---- Opened the serial port /dev/tty.usbserial-110 ----
ets Jul 29 2019 12:21:46

rst:0x1 (POWERON_RESET),boot:0x17 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0030,len:1184
load:0x40078000,len:13192
load:0x40080400,len:3028
entry 0x400805e4



Let's start reading this:


(  0)     0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0
( 32)     0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0
( 64)     0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0
( 96)     0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0
(128)     0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0
(160)     0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0   0
(192)     0

While I should be getting something like this:

---- Opened the serial port /dev/tty.usbserial-110 ----
ets Jul 29 2019 12:21:46

rst:0x1 (POWERON_RESET),boot:0x17 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0030,len:1184
load:0x40078000,len:13192
load:0x40080400,len:3028
entry 0x400805e4



Let's start reading this:


(  0)   123 160 184 191 153  86 115   0   0   0   0   0   0   0   0   0 123 160 184 191 153  86 115   0   0   0   0   0   0   0   0   0
( 32)   123 160 184 191 153  86 115   0   0   0   0   0   0   0   0   0 123 160 184 191 153  86 115   0   0   0   0   0   0   0   0   0
( 64)   123 160 184 191 153  86 115   0   0   0   0   0   0   0   0   0 123 160 184 191 153  86 115   0   0   0   0   0   0   0   0   0
( 96)   123 160 184 191 153  86 115   0   0   0   0   0   0   0   0   0 123 160 184 191 153  86 115   0   0   0   0   0   0   0   0   0
(128)   123 160 184 191 153  86 115   0   0   0   0   0   0   0   0   0 123 160 184 191 153  86 115   0   0   0   0   0   0   0   0   0
(160)   123 160 184 191 153  86 115   0   0   0   0   0   0   0   0   0 123 160 184 191 153  86 115   0   0   0   0   0   0   0   0   0
(192)     0

I have the ESP32 connected to a "MKP-DMX192" board. Photo in attachment.