Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add read burst #50

Merged
merged 2 commits into from Dec 30, 2020
Merged

Conversation

cdonate
Copy link
Contributor

@cdonate cdonate commented Dec 26, 2020

Read all measurements in one read command
Read Datasheed section 4 Data readout for reason behing this feature

Read all measurements in one read command
Read Datasheed section 4 Data readout for reason behing this feature
@nseidle
Copy link
Member

nseidle commented Dec 29, 2020

Hi cdonate - this looks really good but we ask that any large new methods get documented with an example. Do you mind adding one?

add documentation for the default scale on burst read
@cdonate
Copy link
Contributor Author

cdonate commented Dec 30, 2020

I've added the example. I was able to test it on a Arduino Uno and DOIT ESP32.

@nseidle
Copy link
Member

nseidle commented Dec 30, 2020

Works like a charm and the example looks great. Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants