Skip to content

Making changes suggested by @MapleHan in #20 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Making changes suggested by @MapleHan in #20 #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/ICM_20948.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -991,18 +991,18 @@ ICM_20948_Status_e ICM_20948_write_SPI(uint8_t reg, uint8_t *data, uint32_t len,
_spi->transfer(0x00);
_spi->endTransaction();

_spi->beginTransaction(spisettings);
digitalWrite(cs, LOW);
// delayMicroseconds(5);
_spi->beginTransaction(spisettings);
_spi->transfer(((reg & 0x7F) | 0x00));
// SPI.transfer(data, len); // Can't do this thanks to Arduino's poor implementation
for (uint32_t indi = 0; indi < len; indi++)
{
_spi->transfer(*(data + indi));
}
_spi->endTransaction();
// delayMicroseconds(5);
digitalWrite(cs, HIGH);
_spi->endTransaction();

return ICM_20948_Stat_Ok;
}
Expand All @@ -1026,18 +1026,18 @@ ICM_20948_Status_e ICM_20948_read_SPI(uint8_t reg, uint8_t *buff, uint32_t len,
_spi->transfer(0x00);
_spi->endTransaction();

_spi->beginTransaction(spisettings);
digitalWrite(cs, LOW);
// delayMicroseconds(5);
_spi->beginTransaction(spisettings);
_spi->transfer(((reg & 0x7F) | 0x80));
// SPI.transfer(data, len); // Can't do this thanks to Arduino's stupid implementation
for (uint32_t indi = 0; indi < len; indi++)
{
*(buff + indi) = _spi->transfer(0x00);
}
_spi->endTransaction();
// delayMicroseconds(5);
digitalWrite(cs, HIGH);
_spi->endTransaction();

return ICM_20948_Stat_Ok;
}