Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

Most of maxWait arguments are ignored #27

@remrol

Description

@remrol

There are a lot of public getXXX(uint16_t maxWait = 250) methods with default maxWait set to 250. However specified maxWait argument is ignored in most cases since implementation relies on default maxWait

int32_t SFE_UBLOX_GPS::getLatitude(uint16_t maxWait)
{
if (moduleQueried.latitude == false)
getPVT(); <-- Here getPVT uses its default maxWait

IMHO caused by too many default arguments in helper methods like:
sendCommand, sendI2cCommand, waitForResponse, getPVT

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions