Skip to content

Fixes a bug for ESP32 boards #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2018
Merged

Fixes a bug for ESP32 boards #3

merged 1 commit into from
Oct 19, 2018

Conversation

JetseVerschuren
Copy link
Contributor

Because of differences in the wire library for the ESP32 readTempC and readTempF returned static values.

@JetseVerschuren
Copy link
Contributor Author

@awende Can you take a look at this pull request?

@awende awende merged commit 970937f into sparkfun:master Oct 19, 2018
@awende
Copy link
Contributor

awende commented Oct 19, 2018

Tested this out on the ESP8266 and 32 along with a 328p and SAMD21 and everything works. Thank you for fixing this!

@JetseVerschuren JetseVerschuren deleted the patch-1 branch October 20, 2018 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JetseVerschuren @awende