Add SPZ v3, smallest 3 quaternion encoding support #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwegash
changed the title
gwegash
force-pushed
the
george--spz-v3
branch
from
d0aed2a to
c09fbc8
Compare
|
Awesome. Thanks for the patience. I was working on the same code to load spz v3 that I just merged but haven't done the export part yet. Do you want to rebase this PR to add it? Also if you are interested on supporting new formats we don't have yet support for the new version of sogs. Is it something you would be interested in contributing? Thanks! |
gwegash
force-pushed
the
george--spz-v3
branch
from
c09fbc8 to
a3dde5f
Compare
|
@dmarcos Thanks for adding the reader support. I've rebased and included only the writer changes. |
gwegash
changed the title
|
Thank you! |
Closed
|
Just stumbled here and did open a dedicated issue thread for SOG v2/v1 support over here #177 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #151
SPZ v3 has been released with support for smallest 3 quaternion encoding and decoding. The relevant changes are here
This implements support for the latest version of SPZ, and maintains backwards compatibility for reading v2 spz files.
A visual comparison for the mipnerf360 bicycle scene between v2 and v3 is below.