test: conditionally skip depending on net-http-persistent < v4 #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 23, 2021
Net::HTTP::Persistent removed `#retry_change_requests` in v4.0.0 and later, so these tests fail if we've pulled in a more recent version than that. Related to drbrain/net-http-persistent#100
flavorjones
force-pushed
the
flavorjones/fix-tests-for-retry-change-request
branch
from
8ef56fc
to
4fc17ae
Compare
|
OK, everything is green except for Ruby 3.0 which is failing for reasons addressed by #557. Will merge and then move on to that PR. |
flavorjones
deleted the
flavorjones/fix-tests-for-retry-change-request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Net::HTTP::Persistent removed
#retry_change_requestsin v4.0.0 andlater, so these tests fail if we've pulled in a more recent version
than that.
Related to drbrain/net-http-persistent#100