Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nokogiri ruby 2.4.0 compatibility #1566

Closed
kikonen opened this issue Dec 27, 2016 · 5 comments
Closed

Nokogiri ruby 2.4.0 compatibility #1566

kikonen opened this issue Dec 27, 2016 · 5 comments

Comments

@kikonen
Copy link

kikonen commented Dec 27, 2016

Errors with nokogiri 1.6.8.1

::Fixnum is deprecated
/home/jenkins-test/.rvm/gems/ruby-2.4.0@drt_ui/gems/nokogiri-1.6.8.1/lib/nokogiri/html/document.rb:164: warning: constant ::Fixnum is deprecated
/home/jenkins-test/.rvm/gems/ruby-2.4.0@drt_ui/gems/nokogiri-1.6.8.1/lib/nokogiri/html/document.rb:164: warning: constant ::Fixnum is deprecated'
```

NOTE Can't try out nokogiri 1.7.0, due to rails 5.0.1 dependency problems. So wishing to see fix in 1.6.8.x series.

```
Bundler could not find compatible versions for gem "nokogiri":
  In Gemfile:
    nokogiri (~> 1.7.0)

    capybara was resolved to 2.11.0, which depends on
      nokogiri (>= 1.3.3)

    rails (= 5.0.1) was resolved to 5.0.1, which depends on
      actionpack (= 5.0.1) was resolved to 5.0.1, which depends on
        rails-dom-testing (~> 2.0) was resolved to 2.0.0, which depends on
          nokogiri (~> 1.6.0)

    capybara was resolved to 2.11.0, which depends on
      xpath (~> 2.0) was resolved to 2.0.0, which depends on
        nokogiri (~> 1.3)
```
@flavorjones
Copy link
Member

flavorjones commented Dec 27, 2016

@kikonen I've already released v1.7.0 which addresses this.

@flavorjones
Copy link
Member

If you have an issue with Rails's dependencies, you should open an issue there.

@flavorjones
Copy link
Member

I've bumped #rails-contrib, not sure what else to do. We're not planning to do another release of the 1.6.x series

@matthewd
Copy link
Contributor

https://github.com/rails/rails-dom-testing/releases/tag/v2.0.2

@kikonen
Copy link
Author

kikonen commented Jan 2, 2017

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants