Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

precompiled gems should not have a runtime dependency on mini_portile2 #1991

Closed
flavorjones opened this issue Feb 9, 2020 · 5 comments · Fixed by #2008
Closed

precompiled gems should not have a runtime dependency on mini_portile2 #1991

flavorjones opened this issue Feb 9, 2020 · 5 comments · Fixed by #2008
Labels
packaging/native-gem
Milestone
v1.11.0

Comments

@flavorjones
Copy link
Member

As pointed out by @voxik in #1983, any gems that are precompiled don't need mini_portile2 and so we should remove that as a dependency from those gemspecs.
@flavorjones flavorjones added this to the v1.11.0 milestone Feb 9, 2020
@flavorjones flavorjones mentioned this issue Feb 9, 2020
Closed
@larskanis
Copy link
Member

It's already there #1989 !

@flavorjones
Copy link
Member Author

I've merged in @larskanis's PR at #1989. Will be in v1.11.0.rc2.

@flavorjones flavorjones reopened this Feb 26, 2020
@flavorjones
Copy link
Member Author

Reopening, see my comments in #1989.

@flavorjones
Copy link
Member Author

@larskanis Cross-posting here (from #1989) that the change in that PR doesn't seem to work for me. I don't see the cross_compiling block being executed when compiling native linux gems (though it is executed when cross-compiling windows gems).

@larskanis
Copy link
Member

I tested this but probably only with the Windows gems. I'll check this issue this weekend.

larskanis added a commit to larskanis/rake-compiler that referenced this issue Mar 3, 2020
@larskanis
Call cross_compiling block for native platform too
c974a8b 
Currently the cross_compiling block isn't called when cross compiling for the build platform.
This is due to the fact that define_native_tasks() is called first for the build platform
and later on for the cross platforms. The task "native:<gemname>:<platform>" is defined
only once and therefore only without the callback. The callback is therefore not called
for the cross platform that equals the build platform.

OMHO the root issue is that rake-compiler doesn't has a clear separation between
native and cross tasks. However I think calling cross_compiling for any binary gem
(native or cross) is a suitable workaround.

This fixes bug sparklemotion/nokogiri#1991 (comment)
@larskanis larskanis mentioned this issue Mar 3, 2020
Closed
larskanis added a commit to larskanis/nokogiri that referenced this issue Mar 3, 2020
@larskanis
Add a workaround for missing call to cross_compile block
33e5b42 
The cross_compiling block wasn't called for the x86_64-linux platform
leading to an additional dependency to mini_portile2 and missing
post install message.

Patch to rake-compiler is here: rake-compiler/rake-compiler#171

Fixes sparklemotion#1991
@larskanis larskanis mentioned this issue Mar 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
packaging/native-gem
Projects
None yet
Milestone
v1.11.0
Development

Successfully merging a pull request may close this issue.

Add a workaround for missing call to cross_compile block larskanis/nokogiri
2 participants
@flavorjones @larskanis