Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Improve output of inspect and pp for some classes: AttributeDecl, ElementContent, ElementDecl, and EntityDecl
These classes were either:
PP::Node
and overriding#inspect
but not#pretty_print
, orPP::Node
where they could be to simplify thingsAdditionally,
PP::Node#inspect
andPP::Node#pretty_print
no longer munge the names of inspected attributes (e.g.,attribute_nodes
appears as-is instead of asattributes
), and if there is only a singleinspect_attributes
, we omit the key name which makes the XML declarations' output nicer.Have you included adequate test coverage?
Err, no, but these changes should only impact debugging.
Does this change affect the behavior of either the C or the Java implementations?
N/A