fix gumbo memory leak, clean up memcheck suppressions, clean up rubocop todos #2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fragment initialize doesn't call super (intentionally) - exclude test and scripts from Metrics/BlockNesting - exclude test from CollectionLiteralInLoop - the SAX doc start_element_namespace has a lot of optional args
flavorjones
changed the title
|
@stevecheckoway Can you please eyeball the second commit, 4bf4b51 |
stevecheckoway
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Some general cleanup
Have you included adequate test coverage?
All of this is covered by CI currently.
Does this change affect the behavior of either the C or the Java implementations?
N/A