-
-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ext: ruby 3.3 support #3038
ext: ruby 3.3 support #3038
Conversation
ffb5120
to
19b4df0
Compare
48227ea
to
35bec35
Compare
update to rake-compiler-dock 1.4.0.rc1 for experimental 3.3 precompiled support
335ccaa
to
8567974
Compare
I've updated this branch to use rake-compiler-dock v1.4.0.rc1 |
cf8998c
to
da34fd7
Compare
da34fd7
to
7f18190
Compare
Please note this won't get released until one of two things happens:
|
@flavorjones looks like with the release of 3.3 RC1 this morning, the ABI was frozen!
With that, the corresponding issue you linked above has been closed. |
@agrobbin Yup, I saw that, thanks! I'll be working on cutting a final release of rake-compiler-dock this week and will likely ship an RC of nokogiri supporting ruby 3.3 shortly thereafter. |
Thanks @flavorjones!! |
What problem is this PR intended to solve?
Add precompiled native support for Ruby 3.3.
Note that this is still experimental! It is precompiling using a rake-compiler-dock prerelease that uses 3.3.0-preview3.
Have you included adequate test coverage?
Testing against 3.3.0-preview3 or head
Does this change affect the behavior of either the C or the Java implementations?
N/A