Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext: ruby 3.3 support #3038

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Conversation

flavorjones
Copy link
Member

@flavorjones flavorjones commented Nov 26, 2023

What problem is this PR intended to solve?

Add precompiled native support for Ruby 3.3.

Note that this is still experimental! It is precompiling using a rake-compiler-dock prerelease that uses 3.3.0-preview3.

Have you included adequate test coverage?

Testing against 3.3.0-preview3 or head

Does this change affect the behavior of either the C or the Java implementations?

N/A

update to rake-compiler-dock 1.4.0.rc1 for experimental 3.3
precompiled support
@flavorjones flavorjones force-pushed the flavorjones-explore-ruby33-native-support branch from 335ccaa to 8567974 Compare November 26, 2023 21:45
@flavorjones
Copy link
Member Author

I've updated this branch to use rake-compiler-dock v1.4.0.rc1

@flavorjones flavorjones force-pushed the flavorjones-explore-ruby33-native-support branch from cf8998c to da34fd7 Compare November 26, 2023 22:43
@flavorjones flavorjones force-pushed the flavorjones-explore-ruby33-native-support branch from da34fd7 to 7f18190 Compare November 27, 2023 02:38
@flavorjones flavorjones mentioned this pull request Nov 27, 2023
9 tasks
@flavorjones flavorjones merged commit e587fae into main Nov 27, 2023
144 checks passed
@flavorjones flavorjones deleted the flavorjones-explore-ruby33-native-support branch November 27, 2023 22:17
@flavorjones
Copy link
Member Author

Please note this won't get released until one of two things happens:

@flavorjones flavorjones added this to the v1.16.0 milestone Nov 27, 2023
@agrobbin
Copy link

@flavorjones looks like with the release of 3.3 RC1 this morning, the ABI was frozen!

After the release of RC1, we will avoid introducing ABI incompatibilities wherever possible. If we need to do, we’ll announce it in the release note.

With that, the corresponding issue you linked above has been closed.

@flavorjones
Copy link
Member Author

@agrobbin Yup, I saw that, thanks! I'll be working on cutting a final release of rake-compiler-dock this week and will likely ship an RC of nokogiri supporting ruby 3.3 shortly thereafter.

@agrobbin
Copy link

Thanks @flavorjones!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants