remove deprecations in preparation for v1.16 #3041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- XPathVisitorAlwaysUseBuiltins - XPathVisitorOptimallyUseBuiltins
and add comments with deprecation and removal plan to make it easy later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Before a minor release, I generally review deprecations and look for things we can remove.
Nokogiri::HTML5.getwhich was deprecated in v1.12.0. [introduce html4 namespace #2278] (@flavorjones)XPathVisitorAlwaysUseBuiltinsandXPathVisitorOptimallyUseBuiltins, which were deprecated in v1.13.0 in favor ofXPathVisitorconstructor args. [HTML5 documents should not require namespaces in CSS selector queries #2403] (@flavorjones)XML::Reader#attribute_nodeswhich was deprecated in v1.13.8 in favor of#attribute_hash. [bug: v1.13.7 XML::Reader may segfault #2598, fix: XML::Reader XML::Attr garbage collection #2599] (@flavorjones)Also we're now specifying version numbers in remaining deprecation warnings.
Have you included adequate test coverage?
Tests have been removed, otherwise no new coverage needed.
Does this change affect the behavior of either the C or the Java implementations?
As documented above.