Gumbo common options #3205
Merged
Gumbo common options #3205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
merged commit bb8bc2b
into
flavorjones-use-kwargs-html5-methods
129 checks passed
flavorjones
added a commit
that referenced
this pull request
May 28, 2024
**What problem is this PR intended to solve?** While working with @stevecheckoway on #3205, we caught an edge case in how the `max_depth` parameter was converted from signed to unsigned int. It turned out that it would have been caught much earlier with the `-Wconversion` flag, but that flag is useless in Ruby C extensions because of the issue described at https://bugs.ruby-lang.org/issues/20507 That issue was fixed in Ruby 3.4-dev by ruby/ruby#10843 and so I'm using it here and fixing the compilation warnings it flags. **Have you included adequate test coverage?** N/A **Does this change affect the behavior of either the C or the Java implementations?** N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
See discussion at #3199
cc @stevecheckoway
(Recreation of #3204 with additional commits)