-
-
Notifications
You must be signed in to change notification settings - Fork 147
Some updates #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some updates #54
Conversation
Adding more useful parameters.
Making the image optional
Adding my app
Update AlertKitAPI.swift
Update AlertIcon.swift
Update README.md
Update AlertAppleMusic16View.swift
Update AlertAppleMusic17View.swift
Thanks for your PR! I ready to merge, but need remove optional image for custom. If need only text just skip passing alert icon model. |
The optional is just for safety's sake, to prevent the app from crashing if a non-existent image is passed, as when using a UIImageView image. |
It's good idea but developer can use if let condition for safe unwrap. Can you remove it from PR? |
Updated |
I see you changed size of old version, why? |
It seems to me that the old size is too small. The title breaks to a new line for just a few words. Unable to Add |
I see. I follow native one of apple examples, but I see you want customise it. I will think how better solve it. For now proposing drop changes of height and left rest changes with top/bottom and optional changes. |
No description provided.