Skip to content

Conversation

HassanTaleb90
Copy link

No description provided.

@ivanvorobei
Copy link
Member

Thanks for your PR! I ready to merge, but need remove optional image for custom. If need only text just skip passing alert icon model.

@HassanTaleb90
Copy link
Author

The optional is just for safety's sake, to prevent the app from crashing if a non-existent image is passed, as when using a UIImageView image.

@ivanvorobei
Copy link
Member

It's good idea but developer can use if let condition for safe unwrap. Can you remove it from PR?

@HassanTaleb90
Copy link
Author

Updated

@ivanvorobei
Copy link
Member

I see you changed size of old version, why?

@HassanTaleb90
Copy link
Author

I see you changed size of old version, why?

It seems to me that the old size is too small. The title breaks to a new line for just a few words.
Example: "Unable to Add Documentation" ->

Unable to Add
Documentation

@ivanvorobei
Copy link
Member

I see. I follow native one of apple examples, but I see you want customise it. I will think how better solve it.

For now proposing drop changes of height and left rest changes with top/bottom and optional changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants