Skip to content

[UNR-3731][MS] Fix SimPlayer error spam "ServerMove: TimeStamp expired" #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 26, 2020
Merged

[UNR-3731][MS] Fix SimPlayer error spam "ServerMove: TimeStamp expired" #188

merged 3 commits into from
Jun 26, 2020

Conversation

MatthewSandfordImprobable
Copy link
Contributor

Jira: https://improbableio.atlassian.net/browse/UNR-3731

New Blueprint: https://blueprintue.com/blueprint/fnbc2yhd/

Changes:

  • Now use OnClientGainedOwnership instead of begin play to create the AIController.
  • We now toggle enabled on the SimPlayer movement component. I can't remember the details of why this fixes the issue but this is the historic fix for these warnings. It is something to do with not sending movement updates for a certain amount of time before the AIController takes control.

Testing: Tested in a cloud deployment. Saw three of the errors which is much better than thousands.

@improbable-prow-robot
Copy link

Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UNR-3731

@improbable-prow-robot improbable-prow-robot added jira/UNR size/XS Denotes a PR that changes 0-14 lines, ignoring generated files. labels Jun 26, 2020
mironec
mironec approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@mironec mironec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why it works, but such is life sometimes.

@mironec mironec merged commit c3d1142 into 0.10.0-rc Jun 26, 2020
@improbable-prow-robot improbable-prow-robot deleted the bugfix/simplayer-movement branch June 26, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-samiec m-samiec m-samiec approved these changes

+1 more reviewer

@mironec mironec mironec approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@MatthewSandfordImprobable MatthewSandfordImprobable

Labels
jira/UNR size/XS Denotes a PR that changes 0-14 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MatthewSandfordImprobable @improbable-prow-robot @mironec @m-samiec @ImprobableMatthew