fixing authority for deployment manager worker and increased default lobby time in game mode #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lobby time in game mode
spatial/one_worker_test.json
Outdated
| "value": "0" | ||
| }, | ||
| "dimensions": { | ||
| "xMeters": 300, |
There was a problem hiding this comment.
We should keep the dimensions the same as previous config
There was a problem hiding this comment.
reverted dimension changes
| }, | ||
| "chunk_edge_length_meters": 50, | ||
| "streaming_query_interval": 4, | ||
| "legacy_flags": [ |
There was a problem hiding this comment.
Worth checking if any of these legacy flags are required @m-samiec
There was a problem hiding this comment.
The bridge_soft_handover_enabled flag needs to be there I'm pretty sure.
Also how come I don't see the enable_chunk_interest flag? It needs to be disabled since QBI is enabled
There was a problem hiding this comment.
Will add those two in, though it was definitely working without them. Perhaps they default to false if not present?
Vatyx
approved these changes
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deployment manager worker does not have the correct authority set, making it not update the deployment tags properly for the deployment-manager tutorial.
Also, the gamemode only gives about a second to allow players to join a session before the session is made unavailable to new players, and session time is a bit too long.
These changes will fix the authority of the deployment manager worker, change lobby time to half a minute, and session time to 10 minutes.