Bugfix/fix multiserver session state updates #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated server map in LaunchServer.bat to match server default map in editor config
Update map in LaunchServer.bat
Readme image
m-samiec
reviewed
May 30, 2019
m-samiec
reviewed
May 30, 2019
| { | ||
| // There's an offset of 1 between the corresponding states of session progress and session state. | ||
| int SessionState = (int)SessionProgress + 1; | ||
| SendStateUpdate(SessionState); |
There was a problem hiding this comment.
I realise you haven't changed this, but could we switch SendStateUpdate to internally use SessionProgress (and use a static_cast<> to cast it to and int), and offset it by 1 in the component update?
There was a problem hiding this comment.
Is it better now?
m-samiec
reviewed
May 30, 2019
m-samiec
reviewed
May 30, 2019
m-samiec
reviewed
May 30, 2019
m-samiec
approved these changes
May 30, 2019
joshuahuburn
pushed a commit
that referenced
this pull request
May 31, 2019
…on game state is applied.
m-samiec
reviewed
Jun 4, 2019
m-samiec
reviewed
Jun 4, 2019
| } | ||
|
|
||
| void AGDKSessionGameState::SendStateUpdate(int NewState) | ||
| void AGDKSessionGameState::SendStateUpdate(EGDKSessionProgress SessionProgress) |
There was a problem hiding this comment.
This is hiding a member variable name and will cause a warning, perhaps rename to InSessionProgress.
Co-Authored-By: Michael Samiec <michaelsamiec@improbable.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently not doing any authority checks for updating the two session components, this PR makes sure that only the authoritative server makes the updates.
Note: we need to merge release into master (see this PR) before merging this change in, as it will otherwise come with a bunch of unrelated commits.