Skip to content

Feature: CrashBot_Gym fixes for Offloading Tutorial #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 30, 2019
Merged

Feature: CrashBot_Gym fixes for Offloading Tutorial #55

merged 7 commits into from
Sep 30, 2019

Conversation

mattyoung-improbable
Copy link
Contributor

Fixes to the CrashBot_Gym as an offloading example.

  1. Remove Offloading_Gym.
  2. Remove confusing offloading configuration.
  3. Fix warning spam about missing TraceProvider and moving fully simulated skeletal mesh.
  4. Remove need for Crashbot_PlaceInWorld class, make CrashBot support both cases.
  5. Make ShootingComponent error message more useful.

@improbable-prow-robot improbable-prow-robot added jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/L Denotes a PR that changes 150-299 lines, ignoring generated files. labels Aug 29, 2019
@mattyoung-improbable mattyoung-improbable mentioned this pull request Aug 29, 2019
Merged
@mattyoung-improbable mattyoung-improbable changed the base branch from release to master August 29, 2019 13:36
@ernopp ernopp assigned ernopp and unassigned ernopp Sep 26, 2019
@ernopp ernopp self-requested a review September 26, 2019 13:41
@mattyoung-improbable mattyoung-improbable merged commit 960f18b into master Sep 30, 2019
@mattyoung-improbable mattyoung-improbable deleted the feature/crashbots-offloading-ready branch September 30, 2019 09:24
oblm pushed a commit that referenced this pull request Oct 9, 2019
@mattyoung-improbable @oblm
Feature: CrashBot_Gym fixes for Offloading Tutorial (#55)
af85c53 
* Small fixes to Crashbot
* Enable SpatialNetworking, Add more bots + turrets into crashbot map. Add Crashbot_Rifle subclass
* Delete Offloading_Gym map (replaced with Crashbot_Gym). Set Default maps to FPS-Start_Tiny
* Some fixes to stop warning spam due to moving ragdolls and no trace components present
* Remove Engine Association
* Remove unused ShouldMove bool
* Revert default server map
oblm added a commit that referenced this pull request Oct 10, 2019
@oblm
Feature: CrashBot_Gym fixes for Offloading Tutorial (#55) (#62)
904c0a0 
* Small fixes to Crashbot
* Enable SpatialNetworking, Add more bots + turrets into crashbot map. Add Crashbot_Rifle subclass
* Delete Offloading_Gym map (replaced with Crashbot_Gym). Set Default maps to FPS-Start_Tiny
* Some fixes to stop warning spam due to moving ragdolls and no trace components present
* Remove Engine Association
* Remove unused ShouldMove bool
* Revert default server map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-samiec m-samiec m-samiec approved these changes

+1 more reviewer

@ernopp ernopp ernopp approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/L Denotes a PR that changes 150-299 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattyoung-improbable @ernopp @m-samiec @improbable-prow-robot