Skip to content

Fix launch config by removing comma #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2019
Merged

Fix launch config by removing comma #65

merged 1 commit into from
Oct 21, 2019

Conversation

Joe-Improbable
Copy link
Contributor

The json was invalid and couldn't be parsed, so local launches with the CLI wouldn't work.

Use spatial local launch to test.

@improbable-prow-robot improbable-prow-robot added jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/XS Denotes a PR that changes 0-14 lines, ignoring generated files. labels Oct 21, 2019
sjtsilvester
sjtsilvester approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@sjtsilvester sjtsilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joshuahuburn
joshuahuburn approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@joshuahuburn joshuahuburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Banter

@Joe-Improbable Joe-Improbable merged commit 36e6f45 into master Oct 21, 2019
@Joe-Improbable Joe-Improbable deleted the bugfix/fix-default-launch-config branch October 21, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjtsilvester sjtsilvester sjtsilvester approved these changes

+1 more reviewer

@joshuahuburn joshuahuburn joshuahuburn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/XS Denotes a PR that changes 0-14 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Joe-Improbable @sjtsilvester @joshuahuburn @improbable-prow-robot