Feature/unr 2101 allow scheduled builds #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from v3-1569490589-f9345a43b21a6cec-------z to v3-1572523200-2f33678e336fc673-------z
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UNR-2101 |
improbable-prow-robot
added
jira/UNR
size/XS
m-samiec
reviewed
Nov 4, 2019
| - "platform=windows" | ||
| - "scaler_version=2" | ||
| - "queue=${CI_WINDOWS_BUILDER_QUEUE:-v3-1569490589-f9345a43b21a6cec-------z}" | ||
| - "queue=${CI_WINDOWS_BUILDER_QUEUE:-v3-1572610922-3d03d5c2f13b7fa4-------z}" # Has FASTbuild disabled |
There was a problem hiding this comment.
How did you disable fastbuild?
There was a problem hiding this comment.
As suggested by Carl on Slack, I created a new branch of the platform repo without the fastbuild role (https://github.com/improbable/platform/commit/3d03d5c2f13b7fa4642e9e1274dc4ba604a0f551). I baked an image from that and added the corresponding queue here.
m-samiec
approved these changes
Nov 4, 2019
ImprobableVlad
added a commit
that referenced
this pull request
Nov 4, 2019
This reverts commit f181163.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.
Description
Due to a recent Buildkite, scheduled builds no longer have an associated user account - which caused authentication to fail. Engineering Foundations has since introduced an update to fix this, but this requires using a newly baked image and its associated queue. This PR implements the new queue.
Release note
This change is not customer-facing and thus not included in the release notes
Tests
How did you test these changes prior to submitting this pull request?
A green scheduled build can be found here: https://buildkite.com/improbable/unrealgdkexampleproject-nightly/builds/124
What automated tests are included in this PR?
None
STRONGLY SUGGESTED: How can this be verified by QA?
Create a new schedule for this branch, and check whether the build succeeds.
Documentation
No additional documentation has been created
Primary reviewers
@joshuahuburn @m-samiec