Task/unr 1905 improve slack hooks #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImprobableVlad
requested review from
improbable-valy and
mattyoung-improbable
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UNR-1905 |
improbable-prow-robot
added
jira/UNR
size/M
ci/deploy.ps1
Outdated
| $json_message = [ordered]@{ | ||
| text = "Example Project build created by $env:BUILDKITE_BUILD_CREATOR succeeded and a deployment has been launched." | ||
| text = $(if ($env:BUILDKITE_NIGHTLY_BUILD -eq "true") {":night_with_stars: Nightly build of *Example Project*"} ` |
There was a problem hiding this comment.
I'd prefer if this text is prepared outside this block and without the ternary op (looks a bit clunky).
There was a problem hiding this comment.
That's cleaner indeed. I've updated it now.
improbable-valy
approved these changes
Nov 5, 2019
Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com>
Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com>
Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com>
Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com>
Co-Authored-By: improbable-valentyn <32096431+improbable-valentyn@users.noreply.github.com>
mattyoung-improbable
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes sure that a Slack notification is sent regardless of whether a deployment is started or not. The style and info of the Slack message itself has also been updated.
Testing
The Buildkite builds corresponding to this branch are green (https://buildkite.com/improbable/unrealgdkexampleproject-nightly/builds?branch=task%2FUNR-1905-improve-slack-hooks). The new messages can be seen in the
#unreal-gdk-buildschannelDocumentation
This change is not public-facing and has not been documented outside of its associated code.
QA
Create a new build of this branch on Buildkite and add the following to the "Environment Variables" form:
BUILDKITE_SLACK_NOTIFY=trueReviewers
@improbable-valentyn @mattyoung-improbable