[GV-115] Enable multiple engines in CI with Example Project #76
Conversation
…by-scheduled-builds' into feature/ci-multi-engine
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/GV-115 |
improbable-prow-robot
added
jira/GV
size/L
| $deployment_url = "https://console.improbable.io/projects/${project_name}/deployments/${deployment_name}/overview" | ||
| $deployment_button = @{ | ||
| type = "button" | ||
| text = ":cloud: Deployment $($i+1)" |
There was a problem hiding this comment.
Is there a way we can name the deployment after the engine version? Not essential.
There was a problem hiding this comment.
I tried to, but hit the deployment name limit, I guess we could just change the entire format so it no longer includes the full timestamp or the gdk commit or something, but I thought it could be annoying to do.
There was a problem hiding this comment.
Perhaps you could put it in the deployment description? I've never used it, but apparently there is a --deployment_description option when launching a deployment.
There was a problem hiding this comment.
Seems good, I can try that
There was a problem hiding this comment.
Added this, but I can't find the description anywhere in the console :D
ci/generate-pipeline-steps.sh
Outdated
|
|
||
| # Download the unreal-engine.version file from the GDK repo so we can run the example project builds on the same versions the GDK was run against | ||
| GDK_BRANCH_LOCAL="${GDK_BRANCH:-master}" | ||
| curl https://raw.githubusercontent.com/spatialos/UnrealGDK/$GDK_BRANCH_LOCAL/ci/unreal-engine.version -o ci/unreal-engine.version |
There was a problem hiding this comment.
This seems brittle, but I tried git-ing a single file and it was also annoying.
There was a problem hiding this comment.
Agreed that we should try to change this, I will try running some experiments on how we could replace this.
There was a problem hiding this comment.
Didn't find a good replacement, but made this more robust in exchange
| $deployment_url = "https://console.improbable.io/projects/${project_name}/deployments/${deployment_name}/overview" | ||
| $deployment_button = @{ | ||
| type = "button" | ||
| text = ":cloud: Deployment $($i+1)" |
There was a problem hiding this comment.
Perhaps you could put it in the deployment description? I've never used it, but apparently there is a --deployment_description option when launching a deployment.
4 participants
Enables multiple engine versions to be tested simultaneously in CI, by reusing the GDK's unreal-engine.version file.
Engine PR to facilitate this: https://github.com/improbableio/UnrealEngine/pull/289
Reviewers: @ImprobableVlad @joshuahuburn