[UNR-2425][MS] Fixing bug with sim players not moving. #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UNR-2425 |
improbable-prow-robot
added
jira/UNR
size/XS
…s that can be spawned using editor settings.
… rely on it so...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
There are two paths which ask to spawn a default character actor in BP_GDK_PlayerController.
When many SimPlayers clients are run within a short window, for each client, both of these paths are hit.
Fix:
I have made it so that once one path has been hit, we can no longer attempt to spawn another default actor.
Testing:
Tested running 10 SimPlayers locally. Before the fix 20 actors were created. After the fix the correct number (10). I have a few batch files that will aid in testing this. They will be added in another PR.
@m-samiec