Skip to content

Use relative path to zip up sdk artifacts #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Use relative path to zip up sdk artifacts #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions scripts/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,15 @@

set -euo pipefail

if [[ -z ${SDK_VERSION+x} ]];
then
echo "Pls provide SDK_VERSION."
exit 1
if [[ -z ${SDK_VERSION+x} ]]; then
echo "Pls provide SDK_VERSION."
exit 1
fi

if [[ -z ${NUGET_API_KEY+x} ]];
then
echo "NUGET_API_KEY is unset."
# echo "Trying to retrieve from vaults."
# IMPROBABLE_REFRESH_TOKEN="$(imp-ci secrets read --environment=production --buildkite-org=improbable --secret-type=spatialos-service-account --secret-name=platform-sdk)"
if [[ -z ${NUGET_API_KEY+x} ]]; then
echo "NUGET_API_KEY is unset."
# echo "Trying to retrieve from vaults."
# IMPROBABLE_REFRESH_TOKEN="$(imp-ci secrets read --environment=production --buildkite-org=improbable --secret-type=spatialos-service-account --secret-name=platform-sdk)"
fi

REPO_ROOT=$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)
Expand All @@ -26,7 +24,9 @@ rm -rf $ARTEFACT_DIR/*

echo "--- Preparing artefacts for release"
msbuild $REPO_ROOT/apis/apis.csproj /p:Configuration=Release /p:Version=${SDK_VERSION} /t:Clean,Build -verbosity:minimal
zip -r ${ARTEFACT_DIR}/${SDK_VERSION}-net451.zip ${OUTPUT_DIR}/net451
pushd ${OUTPUT_DIR}/net451
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the net451?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure but it seems to be what version of .Net is being targeted (see aspnet/Announcements#98)

zip -r ${ARTEFACT_DIR}/${SDK_VERSION}-net451.zip *
popd
cp ${OUTPUT_DIR}/Improbable.SpatialOS.Platform.${SDK_VERSION}.nupkg ${ARTEFACT_DIR}

echo "--- Publishing to NuGet"
Expand Down