Merge SDK dependencies into one assembly #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lx223
requested review from
jamiebrynes7,
jessicafalk,
a team and
dgavedissian
improbable-prow-robot
added
the
size/M
improbable-prow-robot
added
the
jira/no-ticket
Helcaraxan
suggested changes
Jul 22, 2019
scripts/release.sh
Outdated
| @@ -25,6 +25,7 @@ rm -rf "${ARTEFACT_DIR}" | |||
| mkdir -p "${ARTEFACT_DIR}" | |||
|
|
|||
| echo "--- Preparing artefacts for release" | |||
| msbuild $REPO_ROOT/apis/apis.csproj /t:Restore | |||
There was a problem hiding this comment.
Missing quotes and non-standard bash parameter expansion. Please use the ${} notation.
Helcaraxan
added a commit
that referenced
this pull request
Aug 8, 2019
The ILRepack has introduced type conflict issues that are not easily solved. This boils down to the fact that the public API surface of the Platform SDK exposes types provided by dependencies. ILRepack creates an artificial assembly to export those types. However any user will need to import the original dependency assembly in order to construct function arguments with the types in question. This will result in duplicate type errors as they will exist in both the user-imported dependency and the new artificial assembly created by the ILRepack.
Helcaraxan
added a commit
that referenced
this pull request
Aug 8, 2019
The ILRepack has introduced type conflict issues that are not easily solved. This boils down to the fact that the public API surface of the Platform SDK exposes types provided by dependencies. ILRepack creates an artificial assembly to export those types. However any user will need to import the original dependency assembly in order to construct function arguments with the types in question. This will result in duplicate type errors as they will exist in both the user-imported dependency and the new artificial assembly created by the ILRepack.
Helcaraxan
added a commit
that referenced
this pull request
Aug 8, 2019
The ILRepack has introduced type conflict issues that are not easily solved. This boils down to the fact that the public API surface of the Platform SDK exposes types provided by dependencies. ILRepack creates an artificial assembly to export those types. However any user will need to import the original dependency assembly in order to construct function arguments with the types in question. This will result in duplicate type errors as they will exist in both the user-imported dependency and the new artificial assembly created by the ILRepack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled:
This combines all required DLLs into one to avoid conflicting popular DLLs like Newtonsoft JSON.