Skip to content

Conversation

Helcaraxan
Copy link
Contributor

A set of changes to fix the regeneration scripts and actually regenerate the SDK itself based on fresh upstream API service definitions.

@Helcaraxan Helcaraxan self-assigned this Jul 9, 2019
@improbable-prow-robot improbable-prow-robot added jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/XXL Denotes a PR that changes 600+ lines, ignoring generated files. labels Jul 9, 2019
Copy link

@RNabel RNabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, LGTM overall

Copy link

@RNabel RNabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Helcaraxan Helcaraxan merged commit c0357ef into master Jul 10, 2019
@Helcaraxan Helcaraxan deleted the regenerate-sdk branch July 10, 2019 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/XXL Denotes a PR that changes 600+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants