Beta deployment APIs #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
jira/no-ticket
improbable-prow-robot
added
size/XXL
Helcaraxan
suggested changes
Sep 19, 2019
improbable-prow-robot
removed
the
do-not-merge/work-in-progress
|
Hey @Helcaraxan I've fixed the example code up now so it's ready for review and release once approved. |
sebzz
reviewed
Sep 25, 2019
examples/CapacityLimit/Program.cs
Outdated
| { | ||
| PlayerIdentityToken = playerIdentityTokenResponse.PlayerIdentityToken, | ||
| DeploymentId = _deployment.Id, | ||
| DeploymentId = suitableDeployment.Id.ToString(), |
There was a problem hiding this comment.
What do you mean? Unfortunately this request still takes the deployment id as a string - not much I can do.
sebzz
reviewed
Sep 25, 2019
Helcaraxan
reviewed
Sep 25, 2019
|
It appears that this PR is failing when trying to perform the new calls. Are we sure that the new Beta service is implemented by |
|
@Helcaraxan yes that's true, it's not yet implemented but will be soon. Workflows have a ticket to update this example and I've reverted it back to using the Alpha until then. |
|
@majolo I am not happy merging (and releasing) this if the local flow is not supported. This brings me to another point which is: why are we not removing the Alpha from the SDK? |
Helcaraxan
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/uncc