Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instructions for nodejs + Puppeteer #843

Merged
merged 1 commit into from
May 21, 2024

Conversation

benholmen
Copy link
Contributor

I just went through the Browsershot installation process and ran into a few issues. After reading discussion #681 I found a pretty simple solution that uses the latest versions of nodejs and Puppeteer without locking to an outdated version 17 of Puppeteer.

The critical command seems to be

npx puppeteer browsers install chrome

Which I found from the following error output from Puppeteer:

================ Error Output: ================
Error: Could not find Chrome (ver. 123.0.6312.122). This can occur if either 1. you did not perform an installation before running the script (e.g. `npx puppeteer browsers install chrome`) or 2. your cache path is incorrectly configured (which is: /home/forge/.cache/puppeteer). For (2), check out our guide on configuring puppeteer at https://pptr.dev/guides/configuration

Using the guide in this PR I was able to install Node v22, Puppeteer v22, and Chrome v123.0.6312.122, which are all the latest available version at this time.

@benholmen
Copy link
Contributor Author

I did notice that the documentation mentions nodejs v14, while main mentions v20. It seems that the documentation site is not up to date with this repo.

@iAmKevinMcKee
Copy link

These instructions worked great for me. Would love to see this merged to your docs site. The instructions for some reason are not updated even to what is currently in master.

@freekmurze freekmurze merged commit f845398 into spatie:main May 21, 2024
1 check passed
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants